workflow: added linter and linted src/ folder

src/data/artist.js

@@ -10,7 +10,7 @@ export function formatArtistData(artistData) {
 }
 
 function formatArtistReleases(artistReleases) {
-	let formattedReleases = {}
+	const formattedReleases = {}
 
 	for (const releaseType in artistReleases) {
 		if (artistReleases.hasOwnProperty(releaseType)) {

src/data/search.js

@@ -54,7 +54,7 @@ export function formatAlbums(album) {
 		'EXPLICIT_ALBUM_CONTENT.EXPLICIT_LYRICS_STATUS'
 	)
 
-	if ('number' === typeof isAlbumExplicit) {
+	if (typeof isAlbumExplicit === 'number') {
 		isAlbumExplicit = isAlbumExplicit === 1
 	}
 
@@ -95,9 +95,7 @@ export function formatPlaylist(playlist) {
 		playlistTitle: getPropertyWithFallback(playlist, 'title', 'TITLE'),
 		playlistPictureMedium:
 			getPropertyWithFallback(playlist, 'picture_medium') ||
-			`https://e-cdns-images.dzcdn.net/images/${playlist.PICTURE_TYPE}/${
-				playlist.PLAYLIST_PICTURE
-			}/156x156-000000-80-0-0.jpg`,
+			`https://e-cdns-images.dzcdn.net/images/${playlist.PICTURE_TYPE}/${playlist.PLAYLIST_PICTURE}/156x156-000000-80-0-0.jpg`,
 		playlistLink: getPropertyWithFallback(playlist, 'link') || `https://deezer.com/playlist/${playlist.PLAYLIST_ID}`,
 		playlistTracksNumber: getPropertyWithFallback(playlist, 'nb_tracks', 'NB_SONG'),
 
@@ -107,7 +105,7 @@ export function formatPlaylist(playlist) {
 }
 
 export function formatTitle(track) {
-	const hasTitleVersion = track.trackTitleVersion && track.trackTitle.indexOf(track.trackTitleVersion) === -1
+	const hasTitleVersion = track.trackTitleVersion && !track.trackTitle.includes(track.trackTitleVersion)
 
 	return `${track.trackTitle}${hasTitleVersion ? ` ${track.trackTitleVersion}` : ''}`
 }

src/data/settings.js

@@ -4,12 +4,12 @@ let settingsData = {}
 let defaultSettingsData = {}
 let spotifyCredentials = {}
 
-let cached = false
+const cached = false
 
 export async function getSettingsData() {
 	if (!cached) {
-		let data = await fetchData('getSettings')
-		let { settings, defaultSettings, spotifySettings } = data
+		const data = await fetchData('getSettings')
+		const { settings, defaultSettings, spotifySettings } = data
 		// cached = true
 		settingsData = settings
 		defaultSettingsData = defaultSettings
@@ -36,12 +36,12 @@ export function getInitialPreviewVolume() {
  * @returns	{boolean}
  */
 export function checkInitialSlimDownloads() {
-	return 'true' === localStorage.getItem('slimDownloads')
+	return localStorage.getItem('slimDownloads') === 'true'
 }
 
 /**
  * @returns	{boolean}
  */
 export function checkInitialSlimSidebar() {
-	return 'true' === localStorage.getItem('slimSidebar')
+	return localStorage.getItem('slimSidebar') === 'true'
 }

src/data/standardize.js

@@ -6,7 +6,7 @@ export function standardizeData(rawObj, formatFunc) {
 		const formattedData = []
 
 		for (const dataElement of rawData) {
-			let formatted = formatFunc(dataElement)
+			const formatted = formatFunc(dataElement)
 
 			formattedData.push(formatted)
 		}