trace: remove the TraceEventID and TraceEventVCPUID enums

The TraceEventID and TraceEventVCPUID enums constants are
no longer actually used for anything critical.

The TRACE_EVENT_COUNT limit is used to determine the size
of the TraceEvents array, and can be removed if we just
NULL terminate the array instead.

The TRACE_VCPU_EVENT_COUNT limit is used as a magic value
for marking non-vCPU events, and also for declaring the
size of the trace dstate mask in the CPUState struct.
The former usage can be replaced by a dedicated constant
TRACE_EVENT_VCPU_NONE, defined as (uint32_t)-1. For the
latter usage, we can simply define a constant for the
number of VCPUs, avoiding the need for the full enum.

The only other usages of the enum values can be replaced
by accesing the id/vcpu_id fields via the named TraceEvent
structs.

Reviewed-by: Lluís Vilanova <vilanova@ac.upc.edu>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
Message-id: 1475588159-30598-11-git-send-email-berrange@redhat.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>

This commit is contained in:

Daniel P. Berrange

2016-10-04 14:35:49 +01:00

committed by

Stefan Hajnoczi

parent 79218be42b

commit ef4c9fc854

11 changed files with 48 additions and 65 deletions

									
										trace/event-internal.h
									
		+6
		
												View File
												
				@@ -10,6 +10,12 @@

				#ifndef TRACE__EVENT_INTERNAL_H

				#define TRACE__EVENT_INTERNAL_H

				/*

				 * Special value for TraceEvent.vcpu_id field to indicate

				 * that the event is not VCPU specific

				 */

				#define TRACE_VCPU_EVENT_NONE ((uint32_t)-1)

				/**

				 * TraceEvent:

				 * @id: Unique event identifier.