ui: move qemu_spice_fill_device_address to ui/util.c

Other backends can use it.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Acked-by: Gerd Hoffmann <kraxel@redhat.com>
This commit is contained in:
Marc-André Lureau
2021-02-15 15:10:36 +04:00
parent 5e79d516e8
commit f6ef71bded
7 changed files with 92 additions and 56 deletions
-50
View File
@@ -884,56 +884,6 @@ bool qemu_spice_have_display_interface(QemuConsole *con)
return false;
}
/*
* Recursively (in reverse order) appends addresses of PCI devices as it moves
* up in the PCI hierarchy.
*
* @returns true on success, false when the buffer wasn't large enough
*/
static bool append_pci_address(char *buf, size_t buf_size, const PCIDevice *pci)
{
PCIBus *bus = pci_get_bus(pci);
/*
* equivalent to if (!pci_bus_is_root(bus)), but the function is not built
* with PCI_CONFIG=n, avoid using an #ifdef by checking directly
*/
if (bus->parent_dev != NULL) {
append_pci_address(buf, buf_size, bus->parent_dev);
}
size_t len = strlen(buf);
ssize_t written = snprintf(buf + len, buf_size - len, "/%02x.%x",
PCI_SLOT(pci->devfn), PCI_FUNC(pci->devfn));
return written > 0 && written < buf_size - len;
}
bool qemu_spice_fill_device_address(QemuConsole *con,
char *device_address,
size_t size)
{
DeviceState *dev = DEVICE(object_property_get_link(OBJECT(con),
"device",
&error_abort));
PCIDevice *pci = (PCIDevice *) object_dynamic_cast(OBJECT(dev),
TYPE_PCI_DEVICE);
if (pci == NULL) {
warn_report("Setting device address of a display device to SPICE: "
"Not a PCI device.");
return false;
}
strncpy(device_address, "pci/0000", size);
if (!append_pci_address(device_address, size, pci)) {
warn_report("Setting device address of a display device to SPICE: "
"Too many PCI devices in the chain.");
return false;
}
return true;
}
int qemu_spice_add_display_interface(QXLInstance *qxlin, QemuConsole *con)
{
if (g_slist_find(spice_consoles, con)) {